aosp_build icon indicating copy to clipboard operation
aosp_build copied to clipboard

Published 20 hours ago • verified publisher icon opengapps

ignore TrichromeLibrary since it doesn't extist for arm

Open root-intruder opened this issue 4 years ago • 5 comments

similar to issue #222 I get build errors during makefile gathering for nonexisting packets on arm:

[ 99% 13085/13114] including vendor/opengapps/build/modules/TrichromeLibrary/Android.mk ... FAILED: zipinfo: cannot find or open , .zip or .ZIP. vendor/opengapps/build/modules/GoogleWebViewOverlay/Android.mk: error: TrichromeLibraryGoogle: No source files specified build/make/core/prebuilt_internal.mk:37: error: done. 10:28:56 ckati failed with: exit status 1

...since TrichromeLibrary doesn't exist on arm only on arm64...thus it should be excluded from makefiles

root-intruder avatar Oct 22 '20 10:10 root-intruder

@root-intruder Do you happen to know if Google provides a Chrome/webview variant of arm that depends on trichrome, but has simply not been added to the OpenGapps repos yet?

MarijnS95 avatar Oct 22 '20 11:10 MarijnS95

no I haven't researched much but according to https://github.com/opengapps/aosp_build/issues/253#issuecomment-608975951 there should be...but since I don't want webview etc. in the rom I didn't further research

root-intruder avatar Oct 22 '20 11:10 root-intruder

There exists a TrichromeLibrary for arm and arm64. https://www.apkmirror.com/apk/google-inc/trichrome-library/trichrome-library-86-0-4240-110-release/

I guess this should be added to OpenGapps @mfonville

acr92 avatar Oct 22 '20 13:10 acr92

@nezorflame and @NicholasBuse what is your take on this?

mfonville avatar Oct 22 '20 18:10 mfonville

While it does exist, it never worked for me when I was testing it. Need to take a second look at it though, maybe something changed.

nezorflame avatar Oct 22 '20 18:10 nezorflame