marsha icon indicating copy to clipboard operation
marsha copied to clipboard

Remove apps models from lib-components

Open AntoLC opened this issue 3 years ago • 0 comments

Problem

We added the application models in "lib-components" by convenience, because some components use them, they shouldn't (circular dependency) and it is not the place of these models, they should be in their own packages: apps-model

Solution

  • Refactorize the components in lib-component using the apps models to not use them anymore.
  • Then move back the models in their correct place, apps/classroom/models.ts should be in lib-classroom package.

Ex: UploadManager could have a prop isWithContentType, like that the component will be free of apps model dependency.

AntoLC avatar Nov 08 '22 10:11 AntoLC