✨Needed feature in marsha

[AntoLC]

Feature Request

List of the features needed in order to finish the transition from Grommet to Cunningham design system:

Tabs component

• [ ] Tabs component - https://mui.com/material-ui/react-tabs/

Modal component

• [x] Modal or Dialog component - https://mui.com/material-ui/react-dialog/

Popover component

• [x] #176

---

Textarea component

• [x] #179

---

Select component

• [x] #187
• [x] value with JSX.Element type
• [ ] label with JSX.Element type
• [ ] Virtualization (load data on scroll)
• [ ] required prop
• [ ] suggestion prop, to start the scroll to a specific value
• [ ] searchableFree prop, to search a potential value but let as well the possibility to use the value taped by the user (see example)
• [x] 🐛 In a controlled way (with value), onChange is triggered on the first render.
• [ ] Select without border
• [x] Searcheable without filtering onFocus: https://github.com/openfun/cunningham/pull/166

In this case we need to be able to add an image per option.

[NathanVss]

tbh all these requests seems legit to me. Are they sorted by priority?

[lebaudantoine]

@AntoLC , I'm curious if you might encounter a similar issue with the pop-in position as you did with the date picker component. Has its position already been made dynamic?

[NathanVss]

@AntoLC , I'm curious if you might encounter a similar issue with the pop-in position as you did with the date picker component. Has its position already been made dynamic?

Can you give me more details about this please, I'm curious

[lebaudantoine]

yes ofc @NathanVss, please have a look to this merged PR here, initiated by @AntoLC

[AntoLC]

tbh all these requests seems legit to me. Are they sorted by priority?

Not sorted, no priority.

[AntoLC]

@AntoLC , I'm curious if you might encounter a similar issue with the pop-in position as you did with the date picker component. Has its position already been made dynamic?

Yes, I think there is the same problem. It doesn't seem to impact Marsha though.

[AntoLC]

Searcheable without filtering onFocus

With options = ["France", "England", "Spain"] In a controlled way, if a value is set by default, let's say on France, when the user open the select, only France will be display in the options, it gives the feeling that only France option is available. It would be nice to have the full list onFocus, and to filter only when onInputChange.

@see https://mui.com/material-ui/react-autocomplete/#combo-box

[NathanVss]

Searcheable without filtering onFocus

With options = ["France", "England", "Spain"] In a controlled way, if a value is set by default, let's say on France, when the user open the select, only France will be display in the options, it gives the feeling that only France option is available. It would be nice to have the full list onFocus, and to filter only when onInputChange.

@see https://mui.com/material-ui/react-autocomplete/#combo-box

100% agree, I was made this way because Downshift does it itself ( https://www.downshift-js.com/downshift#usage-with-getrootprops ) - I will change this, it's not intuitive +1

[NathanVss]

Searcheable without filtering onFocus

With options = ["France", "England", "Spain"] In a controlled way, if a value is set by default, let's say on France, when the user open the select, only France will be display in the options, it gives the feeling that only France option is available. It would be nice to have the full list onFocus, and to filter only when onInputChange.

@see https://mui.com/material-ui/react-autocomplete/#combo-box

here is the related PR of this specific request ( https://github.com/openfun/cunningham/pull/166 )