[bug Linux?] Make does not honor comment symbol in addon_config.mk

[artificiel]

trying to disable a line such as

#       ADDON_SOURCES = DeckLinkAPIDispatch.cpp

does not work, it is still considered by the build system. this has the potential to break many addons.

[dimitre]

I'm wondering if this is a Makefile issue instead of PG If yes, maybe it is happening for a while now. it would be great to test on old releases to see if it is like this.

[artificiel]

ah! yes: using make, only editing the addon_config without re-processing with PG can toggle the error. it seems to go back to 0.11.2 at least.

for a moment i was confused as the comments seemed to work again, but i've narrowed it to the tabs... so

these are working:

#Something
# Something
 # Something

but as soon as a tab is introduced, it stops being commented out

#<tab>This is not commented out
# <tab>nor is this
# <tab> or this
#or even<tab>this // this one actually complains about missing separator

i'm surprised this was not causing problems before... but maybe something else is at play?

in any case it's indeed not PG; does github enable transferring issues between repos from PG to OF?

[dimitre]

I suppose it is like this forever and you are the first to find.