projectGenerator icon indicating copy to clipboard operation
projectGenerator copied to clipboard

Latest v.65 doesn't add local frameworks. ofxMidi doesn't add CoreMidi

Open dimitre opened this issue 1 year ago • 3 comments

Latest v.65 doesn't add local frameworks. ofxMidi doesn't add CoreMidi cc: @danoli3

dimitre avatar Jul 31 '24 13:07 dimitre

it seems PG is prepending an absolute path to the addon name

/Volumes/tool/ofw/addons/ofxMidi/CoreMIDI

dimitre avatar Jul 31 '24 13:07 dimitre

I've made this ugly patch locally just to use PG today

	else if(variable == ADDON_FRAMEWORKS){
		size_t found=value.find('/');
		if (found==string::npos) { // This path doesn't have slashes
			addReplaceStringVector(frameworks, value, emptyString, addToValue);

		} else {
			addReplaceStringVectorPre(frameworks, value, addonRelPath, addToValue);
		}
	}

dimitre avatar Jul 31 '24 14:07 dimitre

Nice! Not too ugly and definitely needed. 👍

ofTheo avatar Jul 31 '24 16:07 ofTheo

ok applied here: https://github.com/openframeworks/projectGenerator/pull/558 it can be done better later.

dimitre avatar Jul 31 '24 16:07 dimitre

closed by https://github.com/openframeworks/projectGenerator/pull/558

dimitre avatar Aug 29 '24 18:08 dimitre