projectGenerator icon indicating copy to clipboard operation
projectGenerator copied to clipboard

OF_ROOT in existing Makefile / config.make not set correctly in some cases.

Open bakercp opened this issue 6 years ago • 1 comments

If the Makefile or config.make is in a non-standard location (e.g. where OF_ROOT != ../../..), projectGenerator will modify an existing Makefile / config.make and replace only ../../... Thus for Makefiles that are already correct (e.g. OF_ROOT=../../../../../.. the project generator will correctly determine that OF_ROOT should be ../../../../../.., but will replace the first ../../.. with ../../../../.. resulting in ../../../../../../../.. which results in a broken Makefile / config.make.

Rather than doing a find/replace on a static OF_ROOT string, projectGenerator should replace the whole line or use a regex to replace the entire existing path with its version.

Related #119

bakercp avatar Jun 06 '19 14:06 bakercp

@bakercp I think this one was recently fixed.

dimitre avatar Apr 07 '23 15:04 dimitre