openFrameworks icon indicating copy to clipboard operation
openFrameworks copied to clipboard

Removal of FMOD linking and dylib copying on osx, since it is not being used

Open roymacdonald opened this issue 1 year ago • 0 comments

FMOD is NOT being used on osx and still the dylib is being linked and copied into the app's bundle. this PR removes such.

It is not only disabled by default, it is not possible to enable simply by modifiing the Project.xconfig file as OF_NO_FMOD is being defined in ofConstants.h . Even if I wanted to use FMOD, it will not be that straight forwards.

OF_NO_FMOD defined in ofConstants.h is not the same as the one that is read by xcode_project.sh. The one that the latter reads is the one defined in Project.xcconfig, that is why it needs to be set in it.

This will not break anything as not using FMOD is the default behaviour and not really possible to change by just passing a flag.

Although, I think it is still reasonable to keep the dylib in the core for legacy purposes. (Eventually we should move it into an addon with all fmod related classes)

I guess that it was supposed to be the same variable but it is not.

roymacdonald avatar Oct 19 '24 01:10 roymacdonald