ofBook icon indicating copy to clipboard operation
ofBook copied to clipboard

move from ofVec3f to glm

Open edap opened this issue 6 years ago • 7 comments

Main changes:

  • Add a missing image
  • Remove part regarding operator overloading for vector operations
  • change from ofVec* to glm::vec*
  • update quaternion and vector operation function with the glm ones

Regarding:

/* From-To Rotations */
void ofQuaternion::makeRotate(const ofVec3f& vec1, const ofVec3f& vec2);

I have removed it because in glm there is not a function out of the box to do this. Although we could implement it, look at http://www.opengl-tutorial.org/intermediate-tutorials/tutorial-17-quaternions/ and “RotationBetweenVectors”. In case it is something that we would like to have, i can make a PR for adding this function, that it is pretty useful (I have tested the exact snipper in my own projects).

edap avatar Jan 08 '19 19:01 edap

@OmerShapira it would be nice if you can have a look ;)

edap avatar Jan 08 '19 19:01 edap

Also, the format of the formula it is broken since a while now. @OmerShapira Which tool did you use to format it? is it possible for you to fix it? otherwise I think it make sense to remove it.

edap avatar Jan 09 '19 06:01 edap

ping @OmerShapira

edap avatar Feb 17 '19 19:02 edap

I think it makes sense to remove the broken formulas. @arturoc ?

edap avatar Feb 20 '19 17:02 edap

the syntax highlighting error is related to https://github.com/openframeworks/ofBook/issues/291. I think that apart this issue, that is already tracked n 291, the chapter is up to date with the current OF version.

edap avatar Feb 27 '19 12:02 edap

the rendering issue is server side I'd wager... I seem to remember that certain packages are needed. I would guess running the script that builds the book would give some insight

ofZach avatar Feb 27 '19 12:02 ofZach

@edap I think what we could do is leave this document as it is and add your modifications as a new one + a note at the beginning of this one explaining that since 0.10 OF uses glm instead of our own implementation of vector math. There's still a lot of projects and addons that use ofVec so i think it would be a good idea to keep both versions around.

arturoc avatar Feb 27 '19 16:02 arturoc