ofBook icon indicating copy to clipboard operation
ofBook copied to clipboard

change all smart quotes, worth a thorough review

Open ofZach opened this issue 9 years ago • 9 comments

rich diff might help to make this easier to see.

I basically did a find an replace on all smart single quotes. I figure it will help us standardize things and we can use a javascript / other approach to displaying smart quotes.

ofZach avatar Mar 22 '15 22:03 ofZach

if we merge this, will other PRs by @synesthete get clobbered? I'm happy also to do this after his PRs are merged, since this is a pretty easy to do change and I'd rather not mess with all the great copy editing....

ofZach avatar Mar 22 '15 22:03 ofZach

Nice - thanks for adding the curly quote removal. 44f3b46 caught some things that would definitely have broken pandoc.

Yeah it seems like it would be safer to get @synesthete's PRs into the chapters first.

mikewesthad avatar Mar 22 '15 22:03 mikewesthad

ok I emailed authors individually to take a look, and I'm happy to run the same steps again (it's pretty simple to do / check) once more of the PRs are merged.

ofZach avatar Mar 22 '15 22:03 ofZach

great - thanks for doing that

mikewesthad avatar Mar 22 '15 22:03 mikewesthad

I merge all of @synesthete PRs, will took a look at this issue now.

tpltnt avatar Apr 22 '15 09:04 tpltnt

Hello @tpltnt @bilderbuchi, what's the status on this PR? is it obsolete and can be closed or does it need more work?

edap avatar Oct 25 '18 20:10 edap

I honestly have no idea...

bilderbuchi avatar Oct 26 '18 13:10 bilderbuchi

;) @tpltnt @ofZach @mikewesthad do you think it make sense to close it? It has ~3 years and I doubt we will have time to check the conflict files 1 by 1, probably some of these things went fixed in other PRs. What do you think?

edap avatar Oct 26 '18 23:10 edap

@edap Seems to me that we could close this PR and someone could open a new one after rerunning the sed / find & replace to get rid off curly quotes?

mikewesthad avatar Oct 28 '18 11:10 mikewesthad