protein-ligand-benchmark icon indicating copy to clipboard operation
protein-ligand-benchmark copied to clipboard

[WIP] Adding network edges

Open IAlibay opened this issue 1 year ago • 6 comments

Work done in this PR:

  • [ ] Updated edge yaml format to solve #92
  • [ ] Added actual MSTs generated using the Perses mapper + geometric score

TODO:

  • [x] Add star maps (working with @bobym to get a list of cognate ligands)
  • [ ] Add mutli-star maps?
  • [ ] Other scorers / mappers?

IAlibay avatar Jun 12 '23 12:06 IAlibay

From running a single iteration with perses using these edges I'm facing the following problems with eight (8) of the edges:

cdk8/out_18617587_22.stderr:ValueError: could not convert string to float: ' '
eg5/out_18617580_2.stderr:openmmtools.mcmc.IntegratorMoveError: Potential energy is NaN after 20 attempts of integration with move LangevinDynamicsMove
hif2a/out_18617578_12.stderr:openff.toolkit.utils.exceptions.MoleculeParseError: Unable to read molecule from file: ligands.sdf
shp2/out_18617589_13.stderr:perses.rjmc.atom_mapping.InvalidMappingException: Atom mapping contains no mapped atoms
shp2/out_18617589_20.stderr:perses.rjmc.atom_mapping.InvalidMappingException: Atom mapping contains no mapped atoms
shp2/out_18617589_6.stderr:perses.rjmc.atom_mapping.InvalidMappingException: Atom mapping contains no mapped atoms
shp2/out_18617589_8.stderr:openmmtools.mcmc.IntegratorMoveError: Potential energy is NaN after 20 attempts of integration with move LangevinDynamicsMove

I'll be digging into what's making these error out.

ijpulidos avatar Jul 05 '23 20:07 ijpulidos

Oh, I just realized that the edges information has atom mapping as key, while I'm not sure this is problematic, we probably want to avoid using spaces here, so we want keys to be atom_mapping instead.

ijpulidos avatar Jul 12 '23 17:07 ijpulidos

@ijpulidos : can probably finish out this PR next week after review of currently-running benchmarks.

dotsdl avatar Aug 22 '23 16:08 dotsdl

From @hannahbaumann: failures in edges may be stemming from poorly-equilibrated starting systems. Can be investigated post-merge of the PR.

dotsdl avatar Aug 29 '23 16:08 dotsdl

Any updates on this front? Is anything now blocking this PR?

dotsdl avatar Oct 20 '23 16:10 dotsdl

I believe it's still in QA last I saw @dotsdl

IAlibay avatar Oct 20 '23 17:10 IAlibay