openfoodnetwork icon indicating copy to clipboard operation
openfoodnetwork copied to clipboard

Let people choose which payment methods are available to customers on order cycles

Open cillian opened this issue 2 years ago • 0 comments

What? Why?

For https://github.com/openfoodfoundation/openfoodnetwork/issues/8971, it uses the exact same approach as used in https://github.com/openfoodfoundation/openfoodnetwork/issues/8974.

Notes:

  • This removes the OpenFoodNetwork::AvailablePaymentMethodFilter class and incorporates it into OrderAvailablePaymentMethodsby using a new Spree::PaymentMethod#configured? method. I noticed the Enterprise.ready_for_checkout scope, which calls Spree::PaymentMethod.available doesn't check the things that used to be checked in OpenFoodNetwork::AvailablePaymentMethodFilter i.e. .available will return Stripe payment methods that are not configured with a Stripe account id.

What should we test?

I think the same acceptance and criteria as https://github.com/openfoodfoundation/openfoodnetwork/issues/8974 except replacing shipping methods with payment methods.

Release notes

Changelog Category: User facing changes

Documentation updates

The Order Cycles (for hubs) page in the user guide will probably need to be updated.

cillian avatar Oct 09 '22 13:10 cillian