openfoodnetwork [Shopfront] Link to hub with "hide all references" setup is still displayed in producers profiles

[Shopfront] Link to hub with "hide all references" setup is still displayed in producers profiles

Open audez opened this issue 2 years ago • 3 comments

Description

Even if a hub selects the "hide all references" settings to make its shopfront completely invisible, the reference is still displayed in its producers profiles.

This impacts hubs that want their shops to remain private, for example hubs that have a pro and public shop, because they don't want customers to see that they apply different prices to their products.

Expected Behavior

Reference to the shop must be hidden everywhere (see issue #8896).

Actual Behaviour

Reference is invisible in Producers tab but remains displayed in the producers profiles (popup of producers details), that can be accessed through:

the supplier shop page > Producers tab > click on the supplier shop link > a popup will open, displaying the reference below "SHOP FOR XXX PRODUCTS AT:"
another hub provided by the supplier > Producers tab > click on the supplier shop link > a popup will open, displaying the reference below "SHOP FOR XXX PRODUCTS AT:"

Steps to Reproduce

Connect as admin or superadmin to a hub
In admin dashboard > Enterprises settings, set "Visible in search?" to "Hide all references"
Go to one of the hub producer's shopfront (alternatively, go to another hub provided by the supplier)
Click on the "Producers" tab to display the producers list.
Click on the supplier's link, this opens a popup with producers' details
You can see a link to the hub (below the label "SHOP FOR XXX PRODUCTS AT:")

Animated Gif/Screenshot

This is a hub set up to "Hide all references" : Screen Shot 2022-07-27 at 14 50 06

Connecting to another hub that shares the same supplier, the reference can be found in the "Producers" tab, by clicking on the supplier's link: Screen Shot 2022-07-27 at 14 50 46

Severity

bug-s2: a non-critical feature is broken, no workaround

Possible Fix

In the shop page, in Producers list, in the view that opens when clicking on a producer, hide references to shops that chose the "Hide all references" setting.