openfoodnetwork icon indicating copy to clipboard operation
openfoodnetwork copied to clipboard

[BUU] Variant updates ignored when error on bulk updating products

Open dacook opened this issue 8 months ago • 0 comments

Description

Raised in https://github.com/openfoodfoundation/openfoodnetwork/pull/11750:

When product and associated variant are updated, but there are errors:
Neither should be saved, summary should show, and unsaved values retained with red/orange border. But these fail due to #11748

  1. product has error, variant has error. 🆇 Variant values are lost
  2. product has error, variant has valid changes. 🆇 Variant values are lost
  3. product has valid changes, variant has error. 🆇 Product changes got saved, but shouldn't have been until variant error was resolved Screen Shot 2023-11-02 at 4 30 21 pm

Expected Behavior

Actual Behaviour

Steps to Reproduce

Animated Gif/Screenshot

Workaround

Severity

Your Environment

  • Version used:
  • Browser name and version:
  • Operating System and version (desktop or mobile):

Possible Fix

See https://github.com/openfoodfoundation/openfoodnetwork/issues/11748

dacook avatar Jun 12 '24 00:06 dacook