Improve the Photo Manager using new features from openfoodfacts-dart

[teolemon]

What

• Support for image selection/unselection/cropping/rotation recently landed in openfoodfacts-dart, besides, user need to be able to refresh images.
• [ ] #2428
• [x] Add new photo upload and selection in the Photo manager (expanded view accessible from the photo carousel) (HIGH priority)
• [ ] #2484
• [ ] #2429
• [ ] #2424
• [ ] #2427
• [ ] #2426
• [ ] #2484

Part of

• #503

Code pointers

• https://www.github.com/openfoodfacts/openfoodfacts-dart/commit/1c82e33a313afd3c4908cf95f96d58f7f738ca1e
• https://www.github.com/openfoodfacts/openfoodfacts-dart/commit/c69f3f639f47291a007185c59c89b652bbf52098

Mockups

[teolemon]

I created a new mockup with dual text/icon buttons @monsieurtanuki @M123-dev

[jasmeet0817]

These https://github.com/openfoodfacts/smooth-app/issues/642#issuecomment-954817924 were the mocks previously discussed for adding new image, and carousel navigation.

My 2 cents: I do like Stephane's proposal of a hovering button for adding new images, it goes well with Material app design. And cropping/rotation indeed sound lower priority, I would say we should ignore them completely for now. And when we are ready to implement them, we can rework the design from there, another idea would be to have an edit button where you can perform such modifications.

On Tue, 4 Jan 2022 at 13:37, Pierre Slamich @.***> wrote:

I created a new mockup with dual text/icon buttons @monsieurtanuki https://github.com/monsieurtanuki @M123-dev https://github.com/M123-dev

— Reply to this email directly, view it on GitHub https://github.com/openfoodfacts/smooth-app/issues/766#issuecomment-1004773530, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZRHYSB4USVSEIGI2WO7IDUULSZ7ANCNFSM5K2E4MBQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Cheers, Jasmeet Singh

[teolemon]

• @jasmeet0817 do you have a link to @stephanegigandet 's proposal ?
• Otherwise, I just opened #853

[jasmeet0817]

• https://github.com/openfoodfacts/smooth-app/issues/642#issuecomment-954817924

[teolemon]

[teolemon]

[teolemon]

https://user-images.githubusercontent.com/1689815/213939303-158dae75-0c0b-41e0-bf15-cf40f2b4500f.mp4

[teolemon]

@monsieurtanuki I added a video for future reference

[monsieurtanuki]

@teolemon For future reference this is what we currently have in Smoothie:

screen 1: selected pictures	screen 2: display	screen 3: edit

In your video I can see (on the equivalent of our "screen 2"):

• type selector - we have it but differently
• language selector - we DON'T have it yet
• unselect image - we DON'T have it yet
• take a new photo - we have it but differently
• crop and rotate - we have it but differently
• select an existing image - we DON'T have it yet

Your latest concern is about "select an existing image":

• obviously that should be on our "screen 2"
• that would download the "images" from the server (cache?) and display them in a grid
• when you click on an image in the grid, you land on the crop page
• therefore we should also move the "take new photo" from our screen 3 to screen 2, for consistency (and we would get closer to your legacy interface)

In the end it would look like that (no type and language selector yet):

new screen 2	new screen 3

[teolemon]

This is fixed