smooth-app icon indicating copy to clipboard operation
smooth-app copied to clipboard

Published 20 hours ago • verified publisher icon openfoodfacts

[Nutrition table] A suggestion

Open g123k opened this issue 1 year ago • 4 comments

Hi everyone,

While working on the product edition, I thought about some enhancements for the nutrition table/facts. I have identified 5 issues:

  • The switch for “no nutrition fact” seems inverted (on the left?)
  • The question is negative
  • The serving unit is at the center of the screen without being really understandable for newcomers
  • It’s difficult to understand that we can change the unit
  • We can't select ranges (<, >, ~…)

Hence, my proposal: Artboard

Feel free to share your comments :)

g123k avatar Oct 13 '22 07:10 g123k

@g123k Your suggestion looks great!

My remarks:

  1. as you know off-dart does not support < > for the moment, so that column is not relevant (yet)
  2. the units take too much space for little added value - given the low frequency when a user changes the unit, we would be better off with only one unit and a button
  3. in a near future, we'll have to handle not only "product as sold" data (the standard nutrition table), but also "product as prepared" (e.g. for cocoa powder when mixed with milk), cf. #3046, and it would be great if you could take that into consideration in your design
  4. there's no "save" button in your screen - I think it should always be visible

monsieurtanuki avatar Oct 13 '22 09:10 monsieurtanuki

What happens on narrow screens, and with prepared scrolling ? Does it scroll sideways ?

teolemon avatar Oct 13 '22 09:10 teolemon

Also personal opinion: the table looks intimidating. Very precise, but a bit intimidating (I'm going to break something)

teolemon avatar Oct 13 '22 09:10 teolemon

I really like the table design. It's clear and resembles the one on the packaging.

there's no "save" button in your screen - I think it should always be visible

The save button could be put as an action button on the appbar!

For the rest, I'm with @monsieurtanuki

VaiTon avatar Oct 13 '22 23:10 VaiTon

@g123k Btw I'm currently refactoring the nutriment page: nothing about the display, but as an impact of https://github.com/openfoodfacts/openfoodfacts-dart/pull/570

monsieurtanuki avatar Oct 19 '22 15:10 monsieurtanuki

What if the serving size is not 100 gr. Would there be a way to enter it manually?

galnaf avatar Oct 27 '22 14:10 galnaf

What if the serving size is not 100 gr. Would there be a way to enter it manually?

Yes, that the "serving size" field

g123k avatar Oct 27 '22 15:10 g123k