smooth-app
smooth-app copied to clipboard
openfoodfacts
Some action columns could be rows
What
Image
Yes and no would easily fit into a row, but maybe not on every language a automatic align mode would be perfect
I noticed there's no border in 'No' Button. Can we add border to make both buttons look similar, in terms of UI?
@anshpathania7 Possibly linked to #2988.
I guess the idea would be to have similar displays for negative and positive action, except that background for positive is full, and background for negative is empty but with a border (same color as positive full background).
That would make negative buttons more explicit, especially when the context is a bit confusing.
Okay, I checked the code. Structure of buttons are decided on the basis of screen size currently, it can be turned into row if screen is large or if Axis is provided explicitly. So, for this issue, in automatic align mode should we also consider, string length of languages?
String length wouldn't be enough:
- IIIIIIIIII
- OOOOOOOOOO
Actual display size should be computed instead. How do they do in AutoSizeText to check the display length and decide to use a smaller font?
Seems like this was already addressed.
Should this be used to be designed like this?
It's interesting that this doesn't happen on your devices. I still have this problem in 3.20.0+740 (lastest merged pr from yesterday), probably again something which is depending on the screen size
I'm able to reproduce it if I increase font and display scale on my device. Will try to address it.
Perfect @WildOrangutan I don't know how it's currently solved or what the problem exactly is, but the OverflowBar widget seems promising
Sure @prathamsoni11 I guess the best way to try to reproduce this is using the new Android rezisable emulator or the DevicePreview we have in debug builds