smooth-app icon indicating copy to clipboard operation
smooth-app copied to clipboard

Published 20 hours ago • verified publisher icon openfoodfacts

Fix color on Navigation Bar

Open Jean-BaptisteC opened this issue 2 years ago • 11 comments

What

Navigation Bar doesn't follow themes color (Background Color)

Expected behavior

Add new item navigationBarColor on each themes with Background Color More information here

Screenshot/Mockup/Before-After

Important information

  • Device: Pixel 6
  • OS: Android 13
  • App Version 3.8.1

Jean-BaptisteC avatar Sep 05 '22 18:09 Jean-BaptisteC

Heyy, thanks for filing @Jean-BaptisteC 💯

cc: @g123k

M123-dev avatar Sep 07 '22 16:09 M123-dev

@Jean-BaptisteC Have you tested also on iOS? Because, generally the theme is inverted between the two platforms

g123k avatar Sep 07 '22 16:09 g123k

No, i don't have IOS devices to test but i think it's different because we don't have native navigation bar like Android.

Jean-BaptisteC avatar Sep 07 '22 16:09 Jean-BaptisteC

Looks ok on iOS emulator: Capture d’écran 2022-09-10 à 17 59 17

monsieurtanuki avatar Sep 10 '22 15:09 monsieurtanuki

I would like to look into this issue .

Akashsri3bi avatar Oct 14 '22 06:10 Akashsri3bi

Perfect @Akashsri3bi

M123-dev avatar Oct 14 '22 07:10 M123-dev

@Akashsri3bi I'm unassigning you. Feel free to reclaim the issue.

teolemon avatar Apr 16 '24 14:04 teolemon

I don't think this issue is still relevant. I can't reproduce it + the code seems OK

g123k avatar Apr 16 '24 18:04 g123k

@Jean-BaptisteC is that still an issue for you ?

teolemon avatar Apr 19 '24 07:04 teolemon

Yes, problem is not fixed Top and bottom bar of Android are not sync with background color of app

Jean-BaptisteC avatar Apr 19 '24 07:04 Jean-BaptisteC

Could you elaborate a bit more, as I can't reproduce the issue: Uploading screen-20240419-143137.mp4…

g123k avatar Apr 19 '24 12:04 g123k

@Jean-BaptisteC

M123-dev avatar Jun 07 '24 10:06 M123-dev

Problem is not fixed, check firsts screenshots

Jean-BaptisteC avatar Jun 07 '24 10:06 Jean-BaptisteC

Could you explain a bit more, for me the bar is correct on all pages?

Except on the scanner, but that is wanted because the scanner is showing the camera, thus is mainly theme independent

M123-dev avatar Jun 07 '24 10:06 M123-dev

Color of Android navigation bar is not synced with app background color

Google Chrome Screenshot_20240608-174441

OpenFoodFacts Screenshot_20240608-174604

Jean-BaptisteC avatar Jun 08 '24 15:06 Jean-BaptisteC

Color of Android navigation bar is not synced with app background color

Google Chrome Screenshot_20240608-174441

OpenFoodFacts Screenshot_20240608-174604

Ok, I understand. I close this issue. The real one is to enable Edge to edge mode.

https://github.com/openfoodfacts/smooth-app/issues/4691

g123k avatar Jun 08 '24 17:06 g123k

@Jean-BaptisteC can you upvote the edge to edge issue ? with the 👍 emoji

teolemon avatar Jun 08 '24 18:06 teolemon