smooth-app icon indicating copy to clipboard operation
smooth-app copied to clipboard

⛔️ DO NOT release any version based on Flutter 3.3

Open g123k opened this issue 1 year ago • 14 comments

On the official Flutter GitHub, many issues are reported about regressions with Flutter 3.3. Please DO not release any public version until a fix is released.

Here are the issues, that I'm able to reproduce:

  • Text rendering issues: https://github.com/flutter/flutter/issues/110738
  • Scrolling is not as smooth as before: https://www.youtube.com/watch?v=N66MdEDHh2Q

g123k avatar Sep 04 '22 18:09 g123k

Just checked the last releases, v3.8.1 is the last one before 3.3.0 @teolemon

M123-dev avatar Sep 04 '22 20:09 M123-dev

I suggest that we downgrade to 3.0.5 (actually I did not upgrade), specifically for a version that does not bring interesting features, as @g123k explained. We also had a similar problem this week with an upgrade of mlkit. In general, as I mentioned earlier, we could avoid jumping on every new version of the 50+ packages we use. If needed, that may mean strict version numbers in pubspec.yaml (no ^ I guess). And controlled upgrades once in a while.

monsieurtanuki avatar Sep 04 '22 21:09 monsieurtanuki

I suggest that we downgrade to 3.0.5 (actually I did not upgrade), specifically for a version that does not bring interesting features, as @g123k explained. We also had a similar problem this week with an upgrade of mlkit. In general, as I mentioned earlier, we could avoid jumping on every new version of the 50+ packages we use. If needed, that may mean strict version numbers in pubspec.yaml (no ^ I guess). And controlled upgrades once in a while.

I strongly agree with this change, but will Dependabot still work with strict versions? Being notified of new releases (like bug fixes) would still be interesting.

g123k avatar Sep 04 '22 22:09 g123k

I'm ready to downgrade the code and "fix" the pubspec.yaml. But that means that flutter 3.0.5 needs to be used by the CI bots - if not the code would be rejected. @M123-dev @teolemon?

Being notified of new releases (like bug fixes) would still be interesting.

Indeed we need to find a process. But it's not like we currently used 50+ packages full of bugs: most of them are 100% functional. We can do the upgrade smoothly (and manually), with a focus on specific packages. With no rush.

monsieurtanuki avatar Sep 05 '22 09:09 monsieurtanuki

CI isn't a problem should be one parameter per workflow don't worry about that

M123-dev avatar Sep 05 '22 16:09 M123-dev

The new version of Flutter (3.3.1) doesn’t fix any issues related to the text rendering. We continue with 3.0.

g123k avatar Sep 07 '22 18:09 g123k

totally agree, this version doesn't have any interesting features and it has bugs while rendering.

nimr77 avatar Sep 08 '22 13:09 nimr77

The patches have been made but no version yet. Surely the next version will have them.

lsaudon avatar Sep 13 '22 09:09 lsaudon

https://github.com/flutter/flutter/issues/105014 It doesn't seem to have been fixed

purgeyao avatar Sep 15 '22 03:09 purgeyao

It's now OK to migrate back to 3.3.x, as 3.3.2 fixes the text's issue

g123k avatar Sep 15 '22 14:09 g123k

We decided to upgrade to not have to upgrade multiple versions in the future. But not a high priority

M123-dev avatar Sep 15 '22 16:09 M123-dev

@M123-dev Unfortunately the upgrade has an impact on the code. So, which version should we upgrade to, and when? Possible answer: we'll think about it again on [specify a date]. For the record I'm part of the 25% of developers that do not rush when there's a new version, according to a recent poll :)

monsieurtanuki avatar Sep 15 '22 16:09 monsieurtanuki

I think it should now be OK to upgrade to Flutter 3.3. Otherwise we will have two versions to upgrade on the next Flutter major release.

g123k avatar Oct 13 '22 16:10 g123k

I guess we can reasonably switch to flutter 3.3.4, as it's already the 5th version of 3.3 - they probably fixed most bugs.

monsieurtanuki avatar Oct 13 '22 17:10 monsieurtanuki