ci: Major release update

[M123-dev]

Why

Tracker: #2771 Closes: #2373

What

The main changes in android-release-to-org-openfoodfacts-scanner.yml and ios-release-to-org-openfoodfacts-scanner.yml are the following:

• Changed the (main) trigger from push to release branch to a workflow_call, making it a dispatchable workflow, this allow us to call the workflow from other workflows, this is needed to reuse workflows for multiple release strategies (FDroid, Android, Android Dev listing) but has some limitations, it can't access secrets directly, so we need to pass them from the calling workflow.
• I updated the workflow to allow for some other parameters like the version name + version code
• Passing the flutter cache key as parameter
• android-release.txt Removed
• dartdoc.txt Removed
• ios-release.txt Removed
• issue-label.txt Removed
• postsubmit.yml Fix: codecov not properly working fixes: #2415
• presubmit.yml Also run without PR + don't fail on codecov, fixes: #1580
• release-please.yml Updated to call the release workflows if a release was created, after that gets the old version code and stores the version name and tags the commit and after that runs both android + iOS release simultaneously with passing the before mentioned secrets
• update-xcode.txt deactivated, due to #2091
• CONTRIBUTING.md updated outdated guide
• android/fastlane/Fastfile Split the setVersion function into setVersion and getOldVersionCode
• ios/fastlane/Fastfile Removed setVersion as it wasn't in use anyway since we use the android version code everywhere

---

• The real release (publication to the stores) is currently commented out, this is wanted to first test this whole thing before doing a real release

This PR has many points of failure, I'd love a extensive review @teolemon @VaiTon or others with expierence on this topic, maybe @g123k or @AshAman999

Part of

#2771

[codecov-commenter]

Codecov Report

Merging #2777 (1155a1a) into develop (2ea0da3) will decrease coverage by 1.79%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2777      +/-   ##
==========================================
- Coverage     8.86%   7.07%   -1.80%     
==========================================
  Files          161     219      +58     
  Lines         6623   10802    +4179     
==========================================
+ Hits           587     764     +177     
- Misses        6036   10038    +4002     

Impacted Files	Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart	0.00% <0.00%> (-92.00%)	:arrow_down:
...s/smooth_app/lib/data_models/user_preferences.dart	8.73% <0.00%> (-23.57%)	:arrow_down:
packages/smooth_app/lib/themes/smooth_theme.dart	62.26% <0.00%> (-20.72%)	:arrow_down:
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart	15.70% <0.00%> (-18.51%)	:arrow_down:
...mooth_app/lib/data_models/product_preferences.dart	21.68% <0.00%> (-9.75%)	:arrow_down:
packages/smooth_app/lib/main.dart	14.65% <0.00%> (-3.24%)	:arrow_down:
.../smooth_app/lib/pages/onboarding/welcome_page.dart	0.00% <0.00%> (-3.13%)	:arrow_down:
.../smooth_app/lib/pages/onboarding/scan_example.dart	0.00% <0.00%> (-2.28%)	:arrow_down:
...ackages/smooth_app/lib/pages/scan/scan_header.dart	2.50% <0.00%> (-2.27%)	:arrow_down:
...p/lib/pages/onboarding/consent_analytics_page.dart	0.00% <0.00%> (-1.57%)	:arrow_down:
... and 239 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[VaiTon]

Why did you remove issue-label workflow?

[M123-dev]

It was deactivated (renamed to .txt) anyways, don't know why @teolemon did this

[teolemon]

Because I wanted easy reversibility in case things went wrong

[M123-dev]

So it's fine to completely remove the workflow for now?

[teolemon]

Yes

[M123-dev]

I won't be able to do any fixes until Friday so we should postphone the merge

[teolemon]

Run flutter analyze --fatal-infos --fatal-warnings . Analyzing smooth-app...

info • 'getProductList' is deprecated and shouldn't be used. Use method searchProducts with ProductListQueryConfiguration instead • packages/smooth_app/lib/helpers/data_importer/product_list_import_export.dart:70:63 • deprecated_member_use info • 'ProductListQueryConfiguration' is deprecated and shouldn't be used. Use ProductSearchQueryConfiguration with Barcodes instead • packages/smooth_app/lib/helpers/data_importer/product_list_import_export.dart:72:7 • deprecated_member_use info • 'getProductList' is deprecated and shouldn't be used. Use method searchProducts with ProductListQueryConfiguration instead • packages/smooth_app/lib/pages/product/common/product_list_page.dart:363:65 • deprecated_member_use info • 'ProductListQueryConfiguration' is deprecated and shouldn't be used. Use ProductSearchQueryConfiguration with Barcodes instead • packages/smooth_app/lib/pages/product/common/product_list_page.dart:365:9 • deprecated_member_use info • 'getProducts' is deprecated and shouldn't be used. Use searchProducts instead • packages/smooth_app/lib/query/paged_product_query.dart:40:69 • deprecated_member_use info • 'ToBeCompletedQueryConfiguration' is deprecated and shouldn't be used. Use ProductSearchQueryConfiguration with StatesTagsParameter instead • packages/smooth_app/lib/query/paged_to_be_completed_product_query.dart:13:7 • deprecated_member_use

6 issues found. (ran in 27.0s) Error: Process completed with exit code 1.

[monsieurtanuki]

Run flutter analyze --fatal-infos --fatal-warnings . Analyzing smooth-app...

Indeed I had the same problem, due to new off-dart version 1.24.0, after my first push in #2788. Rather easy to fix. If needed I can code a specific PR.