smooth-app
smooth-app copied to clipboard
feat: Sign up form: try to highlight the issue
In the sign up form, if:
- the email address is already taken
- or the username is already taken
- or the password is invalid
The app will now focus on the incorrect field
Yes, moving it back to a draft.
Waiting for https://github.com/openfoodfacts/openfoodfacts-dart/pull/511 before finalizing this PR
- https://github.com/openfoodfacts/openfoodfacts-dart/pull/511 is merged. We need a release of openfoodfacts-dart @monsieurtanuki @g123k
@g123k release is available in ~2min
@g123k release is available in ~2min
Thanks a lot Marvin. Will be able to finish my PR 🤓
removing the block: https://github.com/openfoodfacts/openfoodfacts-dart/releases/tag/v1.23.0
Codecov Report
Merging #2535 (5387698) into develop (2ea0da3) will decrease coverage by
1.82%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #2535 +/- ##
==========================================
- Coverage 8.86% 7.03% -1.83%
==========================================
Files 161 218 +57
Lines 6623 10654 +4031
==========================================
+ Hits 587 750 +163
- Misses 6036 9904 +3868
Impacted Files | Coverage Δ | |
---|---|---|
...kages/smooth_app/lib/widgets/attribute_button.dart | 0.00% <0.00%> (-92.00%) |
:arrow_down: |
...s/smooth_app/lib/data_models/user_preferences.dart | 8.73% <0.00%> (-23.57%) |
:arrow_down: |
packages/smooth_app/lib/themes/smooth_theme.dart | 62.26% <0.00%> (-20.72%) |
:arrow_down: |
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart | 15.11% <0.00%> (-19.10%) |
:arrow_down: |
...mooth_app/lib/data_models/product_preferences.dart | 21.68% <0.00%> (-9.75%) |
:arrow_down: |
packages/smooth_app/lib/main.dart | 14.65% <0.00%> (-3.24%) |
:arrow_down: |
.../smooth_app/lib/pages/onboarding/welcome_page.dart | 0.00% <0.00%> (-3.13%) |
:arrow_down: |
.../smooth_app/lib/pages/onboarding/scan_example.dart | 0.00% <0.00%> (-2.28%) |
:arrow_down: |
...ackages/smooth_app/lib/pages/scan/scan_header.dart | 2.50% <0.00%> (-2.27%) |
:arrow_down: |
...p/lib/pages/onboarding/consent_analytics_page.dart | 0.00% <0.00%> (-1.57%) |
:arrow_down: |
... and 237 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR is now ready to be merged, as new data is available in the Dart SDK. I have changed a little bit the UI, to recenter the checkboxes and ensure the whole line is clickable.
https://user-images.githubusercontent.com/246838/184594001-e3fb1b58-7a32-4be9-846a-e8a2b90ab838.mp4
ok to merge @g123k @monsieurtanuki ?
For me, it's ok :)
Sure, I did approve!
ok, merging then, one month + between PR and merge