smooth-app icon indicating copy to clipboard operation
smooth-app copied to clipboard

feat: Sign up form: try to highlight the issue

Open g123k opened this issue 2 years ago • 8 comments

In the sign up form, if:

  • the email address is already taken
  • or the username is already taken
  • or the password is invalid

The app will now focus on the incorrect field

g123k avatar Jul 07 '22 16:07 g123k

Yes, moving it back to a draft.

g123k avatar Jul 08 '22 13:07 g123k

Waiting for https://github.com/openfoodfacts/openfoodfacts-dart/pull/511 before finalizing this PR

g123k avatar Jul 11 '22 12:07 g123k

  • https://github.com/openfoodfacts/openfoodfacts-dart/pull/511 is merged. We need a release of openfoodfacts-dart @monsieurtanuki @g123k

teolemon avatar Jul 20 '22 09:07 teolemon

@g123k release is available in ~2min

M123-dev avatar Jul 20 '22 10:07 M123-dev

@g123k release is available in ~2min

Thanks a lot Marvin. Will be able to finish my PR 🤓

g123k avatar Jul 20 '22 10:07 g123k

removing the block: https://github.com/openfoodfacts/openfoodfacts-dart/releases/tag/v1.23.0

teolemon avatar Jul 27 '22 13:07 teolemon

Codecov Report

Merging #2535 (5387698) into develop (2ea0da3) will decrease coverage by 1.82%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2535      +/-   ##
==========================================
- Coverage     8.86%   7.03%   -1.83%     
==========================================
  Files          161     218      +57     
  Lines         6623   10654    +4031     
==========================================
+ Hits           587     750     +163     
- Misses        6036    9904    +3868     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) :arrow_down:
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) :arrow_down:
packages/smooth_app/lib/themes/smooth_theme.dart 62.26% <0.00%> (-20.72%) :arrow_down:
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) :arrow_down:
...mooth_app/lib/data_models/product_preferences.dart 21.68% <0.00%> (-9.75%) :arrow_down:
packages/smooth_app/lib/main.dart 14.65% <0.00%> (-3.24%) :arrow_down:
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) :arrow_down:
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) :arrow_down:
...ackages/smooth_app/lib/pages/scan/scan_header.dart 2.50% <0.00%> (-2.27%) :arrow_down:
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) :arrow_down:
... and 237 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 02 '22 13:08 codecov-commenter

This PR is now ready to be merged, as new data is available in the Dart SDK. I have changed a little bit the UI, to recenter the checkboxes and ensure the whole line is clickable.

https://user-images.githubusercontent.com/246838/184594001-e3fb1b58-7a32-4be9-846a-e8a2b90ab838.mp4

g123k avatar Aug 15 '22 07:08 g123k

ok to merge @g123k @monsieurtanuki ?

teolemon avatar Aug 16 '22 11:08 teolemon

For me, it's ok :)

g123k avatar Aug 16 '22 11:08 g123k

Sure, I did approve!

monsieurtanuki avatar Aug 16 '22 11:08 monsieurtanuki

ok, merging then, one month + between PR and merge

teolemon avatar Aug 16 '22 11:08 teolemon