openfoodfacts-server icon indicating copy to clipboard operation
openfoodfacts-server copied to clipboard

feat: Add short name, value and evaluation to knowledge panels

Open john-gom opened this issue 1 year ago โ€ข 4 comments

What

Create simple, short details for each panel to allow more compact visualisation, e.g. he new two-column approach in the mobile app.

Related issue(s) and discussion

  • Fixes #9368

john-gom avatar Jan 22 '24 11:01 john-gom

Hi @stephanegigandet . Creating a draft pull request so you can review the proposed changes to the knowledge panel schema

john-gom avatar Jan 22 '24 11:01 john-gom

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9db5cd4) 49.44% compared to head (8c9e4e7) 39.18%.

:exclamation: Current head 8c9e4e7 differs from pull request most recent head cb28796. Consider uploading reports for the commit cb28796 to get more accurate results

Files Patch % Lines
lib/ProductOpener/Food.pm 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9683       +/-   ##
===========================================
- Coverage   49.44%   39.18%   -10.27%     
===========================================
  Files          67       63        -4     
  Lines       20644    20164      -480     
  Branches     4978     4882       -96     
===========================================
- Hits        10208     7901     -2307     
- Misses       9139    11130     +1991     
+ Partials     1297     1133      -164     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 22 '24 13:01 codecov-commenter

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 22 '24 15:01 sonarqubecloud[bot]

@john-gom @stephanegigandet any blockers to merging?

cc @g123k

teolemon avatar Feb 14 '24 16:02 teolemon