Vegetable protein isn't recognized as an ingredient

[yuktea]

https://us.openfoodfacts.org/ingredients?status=unknown "vegetable protein" shows up at the top

[alexgarel]

We have to add this to the ingredients taxonomy.

[aakankshabhende]

@alexgarel I would like to work on this issue

[yuktea]

@aakankshabhende thanks! I'll assign it to you. Make sure you join our slack if you feel like you need help

[aakankshabhende]

Sure @yuktea

[aakankshabhende]

@yuktea is there any specific channel on slack for this repository?

[aleene]

The slack channel for the taxonomies is #taxonomies. Check out the ingredients.txt file in the taxonomies folder.

[yuktea]

@yuktea is there any specific channel on slack for this repository?

@aakankshabhende: are you coming here from the Grace Hopper OSD? in that case, join #opensourceday on the Open Food Facts slack

[alexgarel]

open food fact slack

[aakankshabhende]

The slack channel for the taxonomies is #taxonomies. Check out the ingredients.txt file in the taxonomies folder.

@aleene @yuktea will I have to add synonyms of vegetable protein in different languages? My work is almost done, I will make a PR soon

[aakankshabhende]

remote: Permission to openfoodfacts/openfoodfacts-server.git denied to aakankshabhende. I'm facing this issue while making a PR through gitpod

[yuktea]

@aakankshabhende: I suggest you should make a fork first

[aakankshabhende]

I forked it

On Thu, Sep 29, 2022, 10:56 AM Yukti @.***> wrote:

@aakankshabhende https://github.com/aakankshabhende: I suggest you should make a fork first

— Reply to this email directly, view it on GitHub https://github.com/openfoodfacts/openfoodfacts-server/issues/7266#issuecomment-1261767975, or unsubscribe https://github.com/notifications/unsubscribe-auth/APCR2BCJEH4H4DMOXWYTINLWAUR7NANCNFSM5732UINQ . You are receiving this because you were mentioned.Message ID: @.***>

[yuktea]

are you sure you're making changes to your own fork? pushing it to your own fork shouldn't throw that error ideally

[aakankshabhende]

Please check my PR #7425 Thanks a lot for your help @yuktea 😊

[VaiTon]

Despite being in the ingredients taxonomy, it's still an issue:

https://github.com/openfoodfacts/openfoodfacts-server/blob/174b8e3c68846835ad27589f24713b1c0d15d70f/taxonomies/ingredients.txt#L28755

[aleene]

If you open https://world.openfoodfacts.org/ingredient/vegetable-protein it works

[aleene]

Also from us.openfoodfacts.org. So there is a non-taxonomy issue.

[aakankshabhende]

@aleene @VaiTon Is this issue still open to work on?

[alexgarel]

Please do @aakankshabhende but it might be not that simple ! (@benbenben2 is quite an expert in ingredient parsing)

I would recommend setting up a failing test, and then resolving the problem.

[benbenben2]

I am not sure there is anything else to do. Because vegetable protein is synonym of plant protein, when you go to this link: https://us.openfoodfacts.org/ingredient/vegetable-protein It is redirected to https://us.openfoodfacts.org/ingredient/plant-protein

That link does not work (timeout): https://us.openfoodfacts.org/ingredients?status=unknown Though, if vegetable protein is still listed in the unknown ingredients, I believe that it can be solved if you update all these products having that ingredient (edit and save, or ask @stephanegigandet to update all products for that country).

[aleene]

Indeed sounds like it is just a question of reprocessing.