openfoodfacts-server icon indicating copy to clipboard operation
openfoodfacts-server copied to clipboard

Insufficient color contrast on links for page numbers

Open yuktea opened this issue 2 years ago • 8 comments

Description of the issue

This issue was reported by the Accessibility Foundation (https://github.com/openfoodfacts/openfoodfacts-server/issues/4640) Quoting from accessibility_report.pdf Quoting this report: 1.4.3 Contrast (minimum)

On the homepage (https://nl.openfoodfacts.org/) you will find the buttons under the heading "Last added products" with the numbers 2, 3 and etc. The buttons are light gray compared to the white background; the contrast ratio is 2.6: 1 which should be at least 4.5:1 for people with a visual impairment.

image

yuktea avatar Aug 28 '22 22:08 yuktea

Hi, I would like to work on this issue.

MaruthiKo avatar Sep 04 '22 18:09 MaruthiKo

@MaruthiKo you are welcome, it's a matter of tweaking css. Look with dev tools in a browser to understand the rule at play, then find the rule in our code.

It's probably in _off.scss, or another scss file, but it might also be in a .pl or .pm file (if it's inlined in the html).

alexgarel avatar Sep 06 '22 14:09 alexgarel

Alright Done will, look into it

MaruthiKo avatar Sep 06 '22 15:09 MaruthiKo

@alexgarel I would like to work on this issue

aakankshabhende avatar Sep 11 '22 16:09 aakankshabhende

@aakankshabhende you've just been assigned another issue, would you still like to work on it? @MaruthiKo : are you working on it?

yuktea avatar Sep 11 '22 17:09 yuktea

@aakankshabhende you've just been assigned another issue, would you still like to work on it? @MaruthiKo : are you working on it?

Understood the changes but could not find the file to make changes

MaruthiKo avatar Sep 11 '22 17:09 MaruthiKo

Use developer tools in your browser to see which CSS rules are involved.

Eventually add one to customize.

As said above, it's in _off.scss

alexgarel avatar Sep 13 '22 13:09 alexgarel

Yea did try that, it showed that the changes are in _pagination.scss Will look into that again Thanks for the help

MaruthiKo avatar Sep 14 '22 02:09 MaruthiKo