openfoodfacts-server icon indicating copy to clipboard operation
openfoodfacts-server copied to clipboard

adding the tuttifrutti website main page

Open oricdev opened this issue 4 years ago • 8 comments

Hi here, as discussed with Stéphane on slack recently, I suggest adding the html/css/JS standalone version of my tuttifrutti.alwaysdata.net website as-is into html/tuttifrutti. If interested, please tell me on which branch to push the code into. Thanks.

oricdev avatar Jul 16 '20 19:07 oricdev

You can create a new tuttifrutti branch and then make a PR

stephanegigandet avatar Jul 16 '20 19:07 stephanegigandet

hum.. I am actually not familiar at all with this branching process on other's repos: on openfoodfacts / penfoodfacts-server I don't see anything to create a branch. Should I have to clone it into my account and then create a branch from there?? How does it work? thanks for help

oricdev avatar Jul 16 '20 20:07 oricdev

Can we add it as a submodule?

hangy avatar Jul 16 '20 20:07 hangy

Hi Hangy, you mean in Perl? well, I checked with Stephane today and he told me the easiest way to do it for now is to integrate it into html/tuttifrutti. That is what I am trying to do. As for converting into Perl, it will require on my side much more time since I am not familiar at all with Perl unfortunately. Here is message with gikraken once branch "graph_tuttifrutti" has been created image

oricdev avatar Jul 16 '20 20:07 oricdev

@oricdev : one option is to make a fork of the openfoodfacts-server repository, but I just added you in the openfoodfacts-server team, so you should be able to create new branches on it.

stephanegigandet avatar Jul 17 '20 10:07 stephanegigandet

@hangy : I was thinking it would be good to have @oricdev 's code in our repository somewhere. Right now it is completely standalone, but I hope that maybe in the future we can integrate it further, with the look and feel of the OFF site etc.

stephanegigandet avatar Jul 17 '20 10:07 stephanegigandet

@stephanegigandet Hi Stéphane, thank you. I prefer creating a fork so I will push it shortly. If you wish so far to launch for instance since the Display.pl page, just point to the html/tuttifrutti/index.html page with parameters in URL-well-formed format after, like: ?barcode=xxx&country=xxx .. optionally store also. I will try to integrate it further with Perl into OFF look&feel but it may take some time on my side and I may occasionally need some help with Perl to point directly on what I want to do and how without wasting too much time & effort : bascially it should not be that complicated, just adding the resources, lang staff (only english so far) and build the index.html page with Perl (theoretically ;) ).

oricdev avatar Jul 17 '20 14:07 oricdev

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

github-actions[bot] avatar Feb 19 '24 00:02 github-actions[bot]