openfoodfacts-server icon indicating copy to clipboard operation
openfoodfacts-server copied to clipboard

build: Add check_quality service for real-time data validation

Open IsaiahLevy opened this issue 10 months ago โ€ข 3 comments

What

This update introduces a new check_quality service within the APIProductServices module to provide real-time quality warnings and errors for nutrition tables and ingredient lists not directly associated with a product.

Screenshot

Related issue(s) and discussion

  • Fixes #9710

IsaiahLevy avatar Apr 14 '24 19:04 IsaiahLevy

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 49.59%. Comparing base (dc04d18) to head (2d0ac16). Report is 239 commits behind head on main.

Files Patch % Lines
lib/ProductOpener/APIProductServices.pm 0.00% 59 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10129      +/-   ##
==========================================
+ Coverage   49.54%   49.59%   +0.05%     
==========================================
  Files          67       71       +4     
  Lines       20650    20996     +346     
  Branches     4980     5036      +56     
==========================================
+ Hits        10231    10414     +183     
- Misses       9131     9290     +159     
- Partials     1288     1292       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 15 '24 09:04 codecov-commenter

Hi @IsaiahLevy , thanks a lot for the PR. Have you been able to run it successfully locally? Could you add some tests in tests/integration/api_v3_product_services.t to verify that it works as expected? Thank you!

stephanegigandet avatar Apr 18 '24 08:04 stephanegigandet

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 05 '24 18:05 sonarqubecloud[bot]