openfoodfacts-server icon indicating copy to clipboard operation
openfoodfacts-server copied to clipboard

style: created custom tagify scss file and updated gulp file

Open IsaiahLevy opened this issue 10 months ago • 4 comments

What

Implemented a custom SCSS file for Tagify inputs and modified the Gulpfile to include these styles in the build process, allowing for customizable appearance and integration with the project's frontend.

Related issue(s) and discussion

  • Fixes #10030

IsaiahLevy avatar Mar 31 '24 20:03 IsaiahLevy

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.68%. Comparing base (dc04d18) to head (afbee76). Report is 287 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10063      +/-   ##
==========================================
+ Coverage   49.54%   49.68%   +0.13%     
==========================================
  Files          67       71       +4     
  Lines       20650    20982     +332     
  Branches     4980     5026      +46     
==========================================
+ Hits        10231    10424     +193     
- Misses       9131     9266     +135     
- Partials     1288     1292       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 02 '24 10:04 codecov-commenter

@IsaiahLevy, still you are overriding CSS rule, while I think we should only give values to variables as proposed in my comment

alexgarel avatar Apr 16 '24 08:04 alexgarel

@IsaiahLevy you have to fix linting, your changes to gulp file do not concord with lint policy.

make lint might fix it.

alexgarel avatar May 07 '24 21:05 alexgarel