openfoodfacts-ios icon indicating copy to clipboard operation
openfoodfacts-ios copied to clipboard

Layout issue in the Summary tab on the iPhone 5S

Open teolemon opened this issue 3 years ago • 11 comments

  • [ ] Brand clipped
  • [ ] Quantity clipped
  • [ ] NOVA explanation clipped
  • [ ] Empty space next to the NOVA explanation image

teolemon avatar Aug 13 '20 12:08 teolemon

Hey @teolemon what's the expected outcome for this? Like we can't always show the complete brand name if it's long. Let me know ur thoughts. I can fix the constraints!

tejuamirthi avatar Oct 03 '20 17:10 tejuamirthi

Shall we put the name and brand below the images. Note that the ecoscore needs to be added as well.

aleene avatar Oct 03 '20 18:10 aleene

That could work well! Below the image @aleene Where should the store go? More info or any ticket on that?

tejuamirthi avatar Oct 03 '20 19:10 tejuamirthi

Put the name and brand next each other (multiline).

aleene avatar Oct 03 '20 20:10 aleene

Okay @aleene , so now the order of UI elements becomes

  • Left image is unchanged.
  • Product name label is to be updated, multiline and including brand and quantity in two new lines
  • nutriscore and nova are unchanged

Just clarifying in these terms to avoid any further confusions.

Please assign this issue to me so I can start working. Thanks in advance

tejuamirthi avatar Oct 04 '20 02:10 tejuamirthi

Screenshot 2020-10-04 at 12 18 41 PM Hey @aleene here when ther's no nutriscore and it is perfect from the current implementation. If I'm making the brand and quantity as a multiline part of the name. There'd be a huge gap when there's no nutriscore. So please confirm this once

tejuamirthi avatar Oct 04 '20 06:10 tejuamirthi

This is nice, maybe convert the product name ti multiline?

aleene avatar Oct 04 '20 07:10 aleene

Hey @aleene #686 is a part of the issue mentioned here. A solution was proposed there to follow how android does it. Should we proceed with that?

tejuamirthi avatar Oct 05 '20 03:10 tejuamirthi

Looks good

aleene avatar Oct 05 '20 07:10 aleene

Which ones do you want to hide. We are just rearranging?

aleene avatar Oct 05 '20 16:10 aleene

Okay that was my bad for that. It was a confusion from my side. We are just rearranging. I'll make it multiline and share the screenshot for confirmation.

tejuamirthi avatar Oct 05 '20 16:10 tejuamirthi