openfoodfacts-dart icon indicating copy to clipboard operation
openfoodfacts-dart copied to clipboard

Published 20 hours ago • verified publisher icon openfoodfacts

Code base refactoring

Open M123-dev opened this issue 2 years ago • 1 comments

Tracked in

https://github.com/openfoodfacts/openfoodfacts-dart/projects/2

Why

The code of the sdk has grown a lot lately and will probably continue to do so, albeit at a slower pace. To keep the code maintainable a few things will probably have to be changed. The things mentioned here are not decided, only ideas and are open for discussion.

What

  • [ ] #232
  • [ ] #291
  • [ ] #342
  • [x] #339

M123-dev avatar Dec 20 '21 16:12 M123-dev

To me the biggest issue is with #291. I can add fields to Product but I don't know what they're here for, the typical values, what's their unit (if applicable), if they work in READ, in WRITE (https://github.com/openfoodfacts/openfoodfacts-dart/pull/331#issuecomment-997095375), if they are impacted by the states tags (cf. #326). Comments on each field would help, at least in a first approach.

monsieurtanuki avatar Dec 20 '21 18:12 monsieurtanuki