flagr icon indicating copy to clipboard operation
flagr copied to clipboard

(j4k work continuation) Notifier interface, generic webhooks and slack webhooks

Open pacoguzman opened this issue 4 years ago • 4 comments

Description

  • Continuation of the work done at https://github.com/checkr/flagr/pull/240
  • Related to issue #214
  • Add a generic webhook to push updates to flags to a user specified endpoint
  • Add a slack specific webhook to push updates to a slack channel like this:
54704463-b0502080-4b32-11e9-9c89-2d0b87154200

Motivation and Context

We needed notifications around who was doing what with the flags we had active, when they were enabled / disabled etc

If this is accepted in a next iteration we would like to generalize the notifiers so we can not use just HTTP based integrations

How Has This Been Tested?

Manually and with automated tests

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

pacoguzman avatar Oct 16 '20 08:10 pacoguzman

@pacoguzman @zhouzhuojie Hello, will this ever be any day soon?

lightsaway avatar Aug 02 '21 19:08 lightsaway

Is there anything we, as the community, do to move this forward? It would be very valuable to have.

BYK avatar Dec 09 '21 08:12 BYK

Sorry but for the time being I won't be able to contribute to this project

On Thu, Dec 9, 2021, 9:53 AM Burak Yigit Kaya @.***> wrote:

Is there anything we, as the community, do to move this forward? It would be very valuable to have.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/checkr/flagr/pull/410#issuecomment-989639988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACVLW5EAFUJFAFA2N4H3DUQBU7ZANCNFSM4STBJY6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

pacoguzman avatar Dec 09 '21 12:12 pacoguzman

@pacoguzman I'm happy to take over your awesome work and carry it through the finish line.

@zhouzhuojie is the team willing to accept this feature?

BYK avatar Dec 09 '21 12:12 BYK

Stale pull request message

github-actions[bot] avatar Aug 26 '22 21:08 github-actions[bot]

Too bad this wasn't added, would be really helpful for us. :(

mwarkentin avatar Nov 08 '23 14:11 mwarkentin