flagr icon indicating copy to clipboard operation
flagr copied to clipboard

When editing distribution in UI, dragging outside modal closes modal

Open sesquipedalian-dev opened this issue 4 years ago • 0 comments

In the flagr UI, when editing the distribution on a segment, if you use the draggable circle to adjust the distribution to either end (0 or 100%), if you hold your mouse until the cursor is outside the bounds of the modal window, it closes the window. It also does not save your change in this scenario.

Expected Behavior

In this scenario I would expect the modal to remain open. If the modal needs to close, I would expect it to save your change if the new distribution still adds up to 100%.

Current Behavior

The modal closes without saving.

Steps to Reproduce (for bugs)

  1. Run flagr locally:
docker pull checkr/flagr
docker run -it -p 18000:18000 checkr/flagr
  1. open flagr UI: open localhost:18000
  2. Click on the demo flag (demo example)
  3. Click on 'edit' next to the 'distribution' label for the demo segment
  4. Click and drag the circle for the 'blue' variant, releasing your mouse button outside of the modal.
  5. Observe that the modal closes without changing the distribution

Your Environment

  • Version used (flagr version): 1.1.4
  • Server type and version: using docker
  • Operating System and version (uname -a): Darwin scott-agnew 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64
  • Browser: Chrome Version 76.0.3809.87 (Official Build) (64-bit)

sesquipedalian-dev avatar Aug 29 '19 15:08 sesquipedalian-dev