flagr icon indicating copy to clipboard operation
flagr copied to clipboard

Add dd apm tracing for server and db

Open zhouzhuojie opened this issue 5 years ago • 3 comments

Description

Actually, we do need to instrument code to trace http handler and DB

Motivation and Context

How Has This Been Tested?

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

zhouzhuojie avatar Feb 01 '19 18:02 zhouzhuojie

Codecov Report

Merging #212 into master will decrease coverage by 0.24%. The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   86.73%   86.48%   -0.25%     
==========================================
  Files          23       23              
  Lines        1342     1347       +5     
==========================================
+ Hits         1164     1165       +1     
- Misses        127      129       +2     
- Partials       51       53       +2
Impacted Files Coverage Δ
pkg/config/config.go 70.45% <0%> (-9.04%) :arrow_down:
pkg/entity/db.go 73.68% <60%> (-2.79%) :arrow_down:
pkg/config/middleware.go 91.5% <66.66%> (+2.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cc964b...cb12746. Read the comment docs.

codecov-io avatar Feb 01 '19 18:02 codecov-io

Have you considered using opencensus to make this vendor agnostic?

tmc avatar Mar 20 '19 10:03 tmc

@tmc good point! I will try, which opentracing/opencensus compatible package do you recommend?

zhouzhuojie avatar Apr 23 '19 00:04 zhouzhuojie

Stale pull request message

github-actions[bot] avatar Aug 26 '22 21:08 github-actions[bot]