lime-vscode-extension icon indicating copy to clipboard operation
lime-vscode-extension copied to clipboard

Remove Hashlink MacOS debugger catch

Open rcstuber opened this issue 4 years ago • 4 comments

Hi! For a few months Hashlink debugging on MacOS has been integrated. Someone pointed me to a issue with Lime and I found that there still is a legacy OS guard in the code. You can safely remove this block:

https://github.com/haxelime/lime-vscode-extension/blob/c6c3581ae6f556fe56a1bd97827d973e8523d62a/src/lime/extension/Main.hx#L874

Thanks!

rcstuber avatar Dec 25 '20 07:12 rcstuber

You can safely remove this block:

No you can't, this requires a newer HashLink version, and Lime bundles HashLink (1.10 atm IIRC).

Gama11 avatar Dec 25 '20 09:12 Gama11

True, it requires Hashlink v1.12, my assumption was that dependencies are up-to-date always. @Gama11 Merry Christmas ;-)

rcstuber avatar Dec 25 '20 09:12 rcstuber

The blocker is getting new builds, ideally we want a copy of HashLink built using an older macOS version and using an older Linux version (like Ubuntu 16.04). HashLink only has official Windows builds

jgranick avatar Jan 02 '21 20:01 jgranick

Since I don't think official HL Mac/Linux binaries are on the horizon anytime soon, maybe add a from-source compilation step to Lime for Hashlink?

rcstuber avatar Jan 02 '21 20:01 rcstuber