openfisca-core icon indicating copy to clipboard operation
openfisca-core copied to clipboard

Test Python 3.8

Open MaxGhenis opened this issue 4 years ago • 7 comments

Python 3.10 will also be launched in about 6 weeks.

MaxGhenis avatar Aug 24 '21 03:08 MaxGhenis

Thanks @MaxGhenis!

Once #1030 is approved, we should have enough test runners to apply a matrix strategy that should let us test on several Python versions at once :smiley:

In order to help prioritise and avoid resource wastage, could you please share any deployment constraints you have / know of? With which version of Python do you currently use OpenFisca? 🙂

MattiSG avatar Aug 24 '21 09:08 MattiSG

I've been tinkering with a working prototype here #1031 😃 (it works in local if you want to try it out).

bonjourmauko avatar Sep 02 '21 15:09 bonjourmauko

In order to help prioritise and avoid resource wastage, could you please share any deployment constraints you have / know of?

No constraints, though there could be general performance improvements. @nikhilwoodruff also mentioned code structuring improvements in 3.9.

With which version of Python do you currently use OpenFisca?

3.7

MaxGhenis avatar Sep 02 '21 17:09 MaxGhenis

#1030 has been approved, a preliminary implementation in https://github.com/openfisca/openfisca-france/pull/1663 seems to show that 3.7 and 3.8 pass tests, while 3.9 fails at least for the Web API.

MattiSG avatar Sep 03 '21 07:09 MattiSG

@MattiSG great! In #1031 I've got all the tests passing for 3.9 but test_shell_script_with_reform, we can take a look together @HAEKADI if you think it could help.

bonjourmauko avatar Sep 03 '21 10:09 bonjourmauko

@maukoquiroga The api-test keeps running without exiting for Python 3.9. You can take a look at the logs on GitHub Actions. I had to stop the workflow manually 🤔

HAEKADI avatar Sep 06 '21 14:09 HAEKADI

Since Python 3.9 has issues (https://github.com/openfisca/openfisca-core/issues/1035#issuecomment-913693451), I shrunk this issue down to Python 3.8. Python 3.8 support would be especially useful since it's the default conda Python version, and that's how many developers install Python.

MaxGhenis avatar Feb 22 '22 06:02 MaxGhenis