feat: support csv in tuple delete
Description
Added functionality to delete tuples from .csv files.
References
Review Checklist
- [x] I have clicked on "allow edits by maintainers".
- [x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
- [x] The correct base branch is being used, if not
main - [x] I have added tests to validate that the change in functionality is working as expected
- :white_check_mark: login: kindlyturnips (2106262b4d75b1e6920e194d6093624999934578, 2ecd7390b922d7732c65ded7efa8a67f31f6e2f3, 793513d456070f2bbf0320ca53e19b419ba33412, 8903adad5890e66f533cdefed886d84b7e48f062)
- :x: The email address for the commit (d56e0b0ffcca791cf54a02a5f89dd1115d1944f4, 7e724b5032f25300544807e8e8ea8314a195a896, 4f6b139236ecd494ad2944c1f441b16cf2d81fe8) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.
@kindlyturnips Hi! Could you please sign the EasyCLA, so we can approve/merge?
Thanks!
Hi @aaguiarz I'm sorry I was mistaken when I first submitted the pull and signed it as an individual contributor and not a corporate. It seems OpenFGA is owned by Okta (I am not with the organization), this is what I used to sign the EasyCLA. Was this appropriate? Thanks for your patience again.
Hi @kindlyturnips - in order to fix the EasyCLA issue, can I ask you to squash your commits into 1?
You can do git rebase -i HEAD~2, it will show you two lines, replace the first pick in the second one with squash.
It would also be great if you can edit your commit message to follow conventional commit format, e.g. feat: support csv in tuple delete
Hi @rhamzeh,
Thanks for the corrections, I've made the suggested changes. Please let me know if there is anything else, and again thank you for your patience. This is my first open source contribution and I'm learning alot :)
Thanks @kindlyturnips! For a first OSS contribution this is great! Kudos! We're so happy you chose OpenFGA for that milestone, and hopefully this will lead you to much more contributions to this project and others ❤️
Some minor feedback to unblock this PR:
- EasyCLA is still failing. It seems your commit is signed with your local username that is not tied to your github profile. See here on how to do that. Once that is done, you may need to do a
git --ammend - Can you fix the lint issues? You can do that by running
make lintlocally and resolving any problems that come up (let us know if you need any help with this!)
Hi @rhamzeh,
Thanks for the kinds words and encouragement. My local repository somehow got a little jumbled, but I think I straightened everything out. I cleaned up the suggestions from the make lint and the most recent commit should have everything straightened out. If I need to squash it or something else please let me know.
~Chris
👋 hello there! Thanks for putting this PR together. I'm also interested in CSV support in the delete command. Any plans to resurrect this work?
Hey @kindlyturnips! Thanks for the PR. We're cleaning up old/stale PRs and noticed this one has merge conflicts and the CLA isn’t signed. There's still interest in this feature, so if you're up for it, could you update the branch and sign the CLA? Otherwise, we’ll plan to close it in a couple of days to keep things tidy. Let us know!
Hey @kindlyturnips, if you are busy I am happy to take this forward.
@Siddhant-K-code, thoughts?
Sounds good, @bensooraj! Let's get a clean start with your new PR. Thanks!