store icon indicating copy to clipboard operation
store copied to clipboard

Added F# template

Open hayer opened this issue 5 years ago • 6 comments

Added my F# template to the templates.json list, #64.

hayer avatar Jun 04 '19 19:06 hayer

Hi @hayer

Since you built your template we've upped the security requirements on the default OpenFaaS configuration.

You'll need to update your template to use a non-root user and ideally pull in the watchdog binary via a multi-stage build.

Please have a look at how we did it for the "csharp" template in the openfaas/templates repo

cc @rgee0 @burtonr to help if needed

alexellis avatar Jun 04 '19 20:06 alexellis

@alexellis updated the Dockerfile now.

hayer avatar Jun 04 '19 21:06 hayer

Please just do the following now for merge:

  • rebase
  • Add examples to your README.md on how to use the template with a sample or two

alexellis avatar Oct 21 '19 11:10 alexellis

Hello @hayer! I know it's been a little while, but would you be able to complete the final steps to getting this merged?

It'd be best to have a sample function in the readme file to demonstrate how to write a function using your template.

Also, there is now a conflict in the templates.json file that needs to be rebased and resolved before we can merge.

Let me know if you need any help, or have any questions!

burtonr avatar Nov 10 '19 06:11 burtonr

Having a clear-up on GitHub issues / PRs over 1 month old. Let's revisit as necessary. Thank you for the PR.

alexellis avatar Feb 05 '20 12:02 alexellis

Will take a look this weekend. Sorry for the delay.

hayer avatar Feb 07 '20 14:02 hayer