openfaas.github.io icon indicating copy to clipboard operation
openfaas.github.io copied to clipboard

Add spacing between previous and next article links

Open avinashupadhya99 opened this issue 2 years ago • 4 comments

workerB Signed-off-by: avinashupadhya99 [email protected]

Description

Add spaces between the previous and next blog links at the end of each blog.

Motivation and Context

There is no spacing between the previous and next blog links at the end of each blog.

Current - image

Changes with PR - image

Have you applied the editorial and style guide to your post?

See the README.md

N/A

How have you tested the instructions for any tutorial steps?

N/A

Types of changes

  • [ ] New blog post
  • [ ] Updating an existing blog post
  • [ ] Updating part of an existing page
  • [ ] Adding a new page
  • [x] Fixing layout

Checklist:

  • [x] I have given attribution for any images I have used and have permission to use them under Copyright law
  • [x] My code follows the writing-style of the publication and I have checked this
  • [x] I've read the CONTRIBUTION guide
  • [x] I have signed-off my commits with git commit -s

avinashupadhya99 avatar Aug 12 '22 15:08 avinashupadhya99

Thanks for the interest. Can you show how this looks in a responsive mobile view? It may need more testing before it can be merged.

alexellis avatar Aug 15 '22 17:08 alexellis

Here's how it looks on iPhone SE - image On a Pixel5 - image Another responsive view - image

Instead of adding a space between the links, maybe it's a better idea to put the links in separate spans and use a flex grid (Not sure, if that's what it is called. Sorry, my CSS is rusty) ?

avinashupadhya99 avatar Aug 16 '22 04:08 avinashupadhya99

That may be an improvement. It's using Bulma CSS if you're interested in playing around.

alexellis avatar Aug 16 '22 07:08 alexellis

Sorry, made some extra commits due to an accident but here's the result - image image image Desktop - image

avinashupadhya99 avatar Aug 21 '22 12:08 avinashupadhya99

Hi @avinashupadhya99 I noticed this again last week, so am checking out your PR.

Thanks for confirming the layout on mobile.

Alex

alexellis avatar Jan 30 '23 10:01 alexellis