openfaas.github.io icon indicating copy to clipboard operation
openfaas.github.io copied to clipboard

Update 2019-06-13-introducing-openfaas-for-lambda.md

Open mt-kelvintaywl opened this issue 3 years ago • 5 comments

I just noticed a tiny typo in the naming of AWS ECR service; hope this was the correct intention.

Description

Motivation and Context

Have you applied the editorial and style guide to your post?

See the README.md

How have you tested the instructions for any tutorial steps?

Types of changes

  • [ ] New blog post
  • [x] Updating an existing blog post
  • [ ] Updating part of the page page
  • [ ] Adding a new web-page

Checklist:

  • [x] I have given attribution for any images I have used and have permission to use them under Copyright law
  • [x] My code follows the writing-style of the publication and I have checked this
  • [x] I've read the CONTRIBUTION guide
  • [x] I have signed-off my commits with git commit -s

mt-kelvintaywl avatar Jun 25 '21 00:06 mt-kelvintaywl

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

derek[bot] avatar Jun 25 '21 00:06 derek[bot]

Thanks for finding the typo.

Would you like to run the commands that the bot is asking you to, or do you want us to update it instead?

alexellis avatar Jun 25 '21 07:06 alexellis

@alexellis updated with the suggested commands from the bot indeed :) thank you!

mt-kelvintaywl avatar Jun 28 '21 10:06 mt-kelvintaywl

@welteki please can you check if we still need this PR or whether we made the change already? Then I'll merge or close accordingly.

alexellis avatar Jun 16 '22 18:06 alexellis

We did not make these changes yet.

welteki avatar Jun 17 '22 10:06 welteki