ofc-bootstrap icon indicating copy to clipboard operation
ofc-bootstrap copied to clipboard

More configuration in gateway_config

Open Waterdrips opened this issue 4 years ago • 5 comments

Expected Behaviour

There are some settings that we might want to change, such as RO Filesystem, min/max replicas for scaling etc in the gateway_config.yaml, can we make those configurable, with the current values as defaults.

Current Behaviour

https://github.com/openfaas-incubator/ofc-bootstrap/blob/master/templates/gateway_config.yml#L30 https://github.com/openfaas-incubator/ofc-bootstrap/blob/master/templates/gateway_config.yml#L31 https://github.com/openfaas-incubator/ofc-bootstrap/blob/master/templates/gateway_config.yml#L32

Possible Solution

add these as defaults to example.init.yaml, and make them read that default, so we can set custom settings per cluster.

Waterdrips avatar Feb 28 '20 21:02 Waterdrips

Discussed on a call, approved for implementation.

alexellis avatar Mar 10 '20 10:03 alexellis

You should also template buildshiprun limits: https://github.com/openfaas/openfaas-cloud/blob/master/buildshiprun_limits.yml

alexellis avatar Mar 10 '20 10:03 alexellis

check where else limits are set, see if we need to change anything else?

Waterdrips avatar Mar 10 '20 10:03 Waterdrips

Add:

  • function_memory_limit_mb
  • function_cpu_requests_milli
  • function_cpu_limit_milli (we should disable this option for reasons

alexellis avatar Mar 10 '20 10:03 alexellis

going to tackle this as part of moving to use the OFC Helm chart.

Waterdrips avatar Oct 14 '20 09:10 Waterdrips