ingress-operator icon indicating copy to clipboard operation
ingress-operator copied to clipboard

Readme instructions for nginx ingress fail with helm3

Open LucasRoesler opened this issue 4 years ago • 2 comments

The current instructions in the readme https://github.com/openfaas-incubator/ingress-operator#ingresscontroller-nginx

Expected Behaviour

$ helm install nginxingress stable/nginx-ingress --set rbac.create=true
WARNING: This chart is deprecated
NAME: nginxingress
LAST DEPLOYED: Sat Oct 31 17:34:38 2020
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
*******************************************************************************************************
* DEPRECATED, please use https://github.com/kubernetes/ingress-nginx/tree/master/charts/ingress-nginx *
*******************************************************************************************************


The nginx-ingress controller has been installed.
It may take a few minutes for the LoadBalancer IP to be available.
You can watch the status by running 'kubectl --namespace default get services -o wide -w nginxingress-nginx-ingress-controller'

An example Ingress that makes use of the controller:

  apiVersion: extensions/v1beta1
  kind: Ingress
  metadata:
    annotations:
      kubernetes.io/ingress.class: nginx
    name: example
    namespace: foo
  spec:
    rules:
      - host: www.example.com
        http:
          paths:
            - backend:
                serviceName: exampleService
                servicePort: 80
              path: /
    # This section is only required if TLS is to be enabled for the Ingress
    tls:
        - hosts:
            - www.example.com
          secretName: example-tls

If TLS is enabled for the Ingress, a Secret containing the certificate and key must also be provided:

  apiVersion: v1
  kind: Secret
  metadata:
    name: example-tls
    namespace: foo
  data:
    tls.crt: <base64 encoded cert>
    tls.key: <base64 encoded key>
  type: kubernetes.io/tls

Current Behaviour

$ helm install stable/nginx-ingress --name nginxingress --set rbac.create=true
Error: unknown flag: --name

Possible Solution

Update the helm install instructions, we should also update which repo it is using.

Your Environment

$ helm version
version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"dirty", GoVersion:"go1.14.3"}

LucasRoesler avatar Oct 31 '20 16:10 LucasRoesler

@LucasRoesler did this get fixed?

alexellis avatar Mar 17 '21 15:03 alexellis

@alexellis No, the instruction still fails.

These instructions have not been modified since the issue was opened https://github.com/openfaas/ingress-operator/blame/master/README.md#L93

LucasRoesler avatar Mar 18 '21 11:03 LucasRoesler