faasd icon indicating copy to clipboard operation
faasd copied to clipboard

Populate the memory limits of functions in the REST API

Open alexellis opened this issue 4 years ago • 4 comments

Expected Behaviour

When users list or query functions from the REST API, then the memory limits set on the functions should be returned in the JSON response.

Current Behaviour

They are being accepted upon deployment, but not being populated when querying.

List all Possible Solutions

Try to read back from the task or container definition.

Update here:

https://github.com/openfaas/faasd/blob/master/pkg/provider/handlers/functions.go

https://github.com/openfaas/faasd/blob/master/pkg/provider/handlers/read.go

Context

Required for terraform provider and API compliance.

alexellis avatar May 19 '21 16:05 alexellis

I would like to do that, if no one wants to 🙋🏻‍♂️

developer-guy avatar May 19 '21 17:05 developer-guy

Given how long has passed since you volunteered to help, this issue is now fair game for anyone who wants to contribute.

Nobody is working on this at present.

alexellis avatar Sep 15 '21 11:09 alexellis

/add label: help wanted, good first issue

alexellis avatar Sep 17 '21 08:09 alexellis

@Shikachuu I don't think we have any CPU limits at this stage, so this just covers memory being populated back again from what was inputted.

See also: https://github.com/openfaas/faasd/commit/9e5eb84236865069396adc29d3e5855d5d42a70a

alexellis avatar Sep 18 '21 09:09 alexellis