faas-cli
faas-cli copied to clipboard
Added ability to include annotations in template.yml for inclusion in…
Added ability to include annotations in template.yml for inclusion in function.yml on new command
Signed-off-by: Whit Matthews [email protected]
Description
Motivation and Context
- [x] I have raised an issue to propose this change (required)
How Has This Been Tested?
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I've read the CONTRIBUTION guide
- [x] I have signed-off my commits with
git commit -s
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
@alexellis I thought I'd try my hand at working the feature request I added yesterday. I'm new to golang though so please let me know if I missed anything. Thanks!
Sorry this issue was not approved or discussed yet. The contributing guide needs approval from a maintainer before changes are submitted. This is quite common, the Docker project uses the same standards.
/add label: not/approved
Understood. Is there any action needed from me at the moment or do I just need to wait until it's discussed and approved?
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.
Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.
:bulb: Shall we fix this?
This will only take a few moments.
First, clone your fork and checkout this branch using the git CLI.
Next, set up your real name and email address:
git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"
Finally, run one of these commands to add the "Signed-off-by" line to your commits.
If you only have one commit so far then run: git commit --amend --signoff
and then git push --force
.
If you have multiple commits, watch this video.
Check that the message has been added properly by running "git log".
Hey Whit, we are going to need an issue creating for this.
Let's close the PR, we can always reopen it after a discussion.
I also haven't heard back from you or your colleague on the email thread you started with us, can you take a look please?
Alex