faas-cli icon indicating copy to clipboard operation
faas-cli copied to clipboard

Add support for stack.yaml in addition to stack.yml

Open ad-si opened this issue 5 years ago • 9 comments

According to the docs the official file extension is .yaml (https://yaml.org/faq.html) and therefore it should be supported!

ad-si avatar Jul 24 '19 12:07 ad-si

Let's monitor this suggestion to see how much demand there is.

alexellis avatar Jul 24 '19 13:07 alexellis

Thanks for your interest. Please could you have a look at the various different repos we have and what each does?

alexellis avatar Jul 24 '19 13:07 alexellis

Thanks for your interest. Please could you have a look at the various different repos we have and what each does?

Sorry, I'm used to monorepos. Will be more considerate in the future 😅

ad-si avatar Jul 24 '19 13:07 ad-si

You're right about the website, but practice says different: https://stackoverflow.com/questions/21059124/is-it-yaml-or-yml

I think it will remain as stack.yml unless we have a significant reason to alter it. Engineering effort and maintenance doesn't come for free.

Thanks for the suggestion though. Perhaps some of these would be better as conversational comments on Slack?

alexellis avatar Jul 24 '19 20:07 alexellis

I believe we already have this covered. It can be see in faas.go.

martindekov avatar Jul 28 '19 13:07 martindekov

It should be slightly augmented in order to work, I guess if needed can be easily done.

martindekov avatar Jul 28 '19 13:07 martindekov

I think that reference is for the auto-completion.

alexellis avatar Jul 28 '19 18:07 alexellis

I am summoning this issue back again :P we should have yaml first supported then yml if both files are given at the same time, let's use yaml? I checked it but it looks very straight forward to add.(only downside is just gotta update the docs wherever stack.yml is written) YAML/YML are both the same btw so it makes sense to support yaml. yml-yaml

mrwormhole avatar Aug 25 '21 08:08 mrwormhole

Thanks for the message.

We haven't seen any strong interest or particular frustration from the community in this, so I would almost be tempted to let it sit here and perhaps not make the change. You can always use -f stack.yaml if that feels more natural than using a file named stack.yml

alexellis avatar Aug 26 '21 15:08 alexellis