connector-sdk icon indicating copy to clipboard operation
connector-sdk copied to clipboard

Error Response when no matching functions

Open prsh9 opened this issue 3 years ago • 1 comments

Description

Send response to indicate no matching functions are found for the topic.

Motivation and Context

Currently when invoking a function on a topic with controller.Invoke() and there are no matching functions (probably due to function still being loaded, topic-map not refreshed) there is no way to acknowledge upstream. Consider using amqp which uses manual auto-ack, there is no way to determine the failure and do a negative ack / track such invocation failure.

Fixes issue #61

  • [x] I have raised an issue to propose this change (required)
  • [ ] My issue has received approval from the maintainers or lead with the design/approved label

How Has This Been Tested?

Performed manual testing and recorded the behaviour.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I've read the CONTRIBUTION guide
  • [x] I have signed-off my commits with git commit -s
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

prsh9 avatar Aug 26 '21 16:08 prsh9

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

derek[bot] avatar Aug 26 '21 16:08 derek[bot]