node8-express-template icon indicating copy to clipboard operation
node8-express-template copied to clipboard

Published 20 hours ago • verified publisher icon openfaas-incubator

Update Base Image to Node 10

Open Templum opened this issue 6 years ago • 4 comments

Node 10 will be released on the 2018-10-30 and will become the new LTS. If that happens we should update the base image to Node 10.

Also it might be advisable to rename the repository. As it containts node8

Templum avatar Oct 25 '18 13:10 Templum

Renaming the repository will break for so many people, that's not really an option.

A new repository with an alternative name seems like the sane thing to do right now - that or make "LTS" a moving target - node-lts-express (but this may also cause breakage for people moving between LTS versions).

Alex

alexellis avatar Oct 26 '18 08:10 alexellis

https://github.com/openfaas-incubator/node10-express-template

alexellis avatar Oct 26 '18 08:10 alexellis

@alexellis Why did you not created node-express-template instead of node10-express-template ? I don't understand why it's necessary to add node version into the name of the repository.

rimiti avatar Oct 26 '18 10:10 rimiti

It's important to make sure that we do not break a user's functions and production workflow. If there is a breaking change between two Node versions then that needs to be mitigated. By using a version in the repository we can allow both to be used at once and leave it up to the developer/company to move when they want. Does this make sense?

alexellis avatar Oct 28 '18 16:10 alexellis