Whisper: Full RPC integration

[bjornwgnr]

trafficstars

@rphmeier should be able to provide additional information if necessary

• [ ] split removal for pairs and sym keys
• [ ] max size for pool

[rphmeier]

I can't provide any more information. Whisper RPC integration is already complete AFAIK

[bjornwgnr]

Whisper RPC integration is already complete AFAIK

Can someone else confirm that? @tomusdrw

[5chdn]

Having a hard time not to be confused about this ticket. :rofl:

[tomusdrw]

https://github.com/ethereum/go-ethereum/wiki/Whisper-v5-RPC-API Lists following methods:

shh_addPrivateKey
shh_addSymKey
shh_deleteKeyPair
shh_deleteMessageFilter
shh_deleteSymKey
shh_generateSymKeyFromPassword
shh_getFilterMessages
shh_getPrivateKey
shh_getPublicKey
shh_getSymKey
shh_hasKeyPair
shh_hasSymKey
shh_info
shh_markTrustedPeer
shh_newKeyPair
shh_newMessageFilter
shh_newSymKey
shh_post
shh_setMaxMessageSize
shh_setMinPoW
shh_subscribe
shh_unsubscribe
shh_version

Our wiki: https://wiki.parity.io/JSONRPC-shh-Module

shh_addPrivateKey
shh_addSymKey
shh_deleteKey
shh_deleteMessageFilter
shh_getFilterMessages
shh_getPrivateKey
shh_getPublicKey
shh_getSymKey
shh_info
shh_newKeyPair
shh_newMessageFilter
shh_newSymKey
shh_post
shh_subscribe
shh_unsubscribe

Diff:

$ diff whisper.go whisper.parity 
3c3
< shh_deleteKeyPair
---
> shh_deleteKey
5,6d4
< shh_deleteSymKey
< shh_generateSymKeyFromPassword
11,12d8
< shh_hasKeyPair
< shh_hasSymKey
14d9
< shh_markTrustedPeer
19,20d13
< shh_setMaxMessageSize
< shh_setMinPoW
23d15
< shh_version

@bjornwgnr @rphmeier what do we understand as Full RPC Integration? What's our stance on the inconsistency in naming (shh_deleteKey vs shh_deleteKeyPair) and those additional methods implemented by go Whisper v5?

[bjornwgnr]

@5chdn @tomusdrw this is a ticket/description that @rphmeier once provided me with which is why I tagged him

[rphmeier]

@bjornwgnr sorry, I don't remember that but I am getting over a bad flu so things are a little fuzzy.

So if the issue is that we want to follow Geth Whisper RPC then we can rename it to that. Although given we're having a hard time implementing a wire protocol which both codebases agree upon it might be a little too early. In terms of RPC compatibility there are some things (trusted peer for example) which I don't agree with and I'd prefer if we put forward an EIP for a standardized set of APIs