fether icon indicating copy to clipboard operation
fether copied to clipboard

Make it so users cannot simply copy paste the recovery phrase in Create New Account flow

Open pmespresso opened this issue 6 years ago • 4 comments

Several other wallets do this to make absolute sure the user actually did make a copy of the phrase.

The ideal behavior would be:

  • the rewrite recovery phrase screen input should override Command V behavior to pop up a warning message along the lines of "We have disabled Copy/Pasting for this step to be certain you made a copy of the recovery phrase. Please go back to the previous screen and make a copy if you haven't already."

Edit: - Check if process.env.NODE_ENV !== 'production' then just allow copy/paste since it'd be very annoying not to have that in development

pmespresso avatar Feb 04 '19 03:02 pmespresso

I'd like to still be able to copy/paste the recovery phrase in development

ltfschoen avatar Feb 04 '19 03:02 ltfschoen

We can check for NODE_ENV and allow it if not in production?

pmespresso avatar Feb 04 '19 03:02 pmespresso

Yes, good idea.

Several other wallets do this to make absolute sure the user actually did make a copy of the phrase.

Following #100, I'd actually go the way Signer, Status and Exodus do: we don't force the user to make a copy of the phrase, just put a warning "account not backed up" if it's not backed up yet. This issue is still valid though.

amaury1093 avatar Feb 04 '19 10:02 amaury1093

Should we close then? ~~I'll open several issues to break down #100 later on.~~ edit: just saw https://github.com/paritytech/fether/pull/400 addresses most of it, we can open another issue for what's left.

Tbaut avatar Feb 11 '19 04:02 Tbaut