openelections-data-tx icon indicating copy to clipboard operation
openelections-data-tx copied to clipboard

Use git pre-commit hooks to verify changes

Open crass opened this issue 5 years ago • 3 comments

I'm not sure the best way to do this, but it seems like we might want some functionality where created pull requests are checked to verify that they meet the CONTRIBUTING.md rules and perhaps some extra ones, like normalized names, no empty field names, no empty rows, etc.. I believe this can be implemented with a webhook triggered on pull request creation.

crass avatar Oct 29 '19 03:10 crass

I played around with this thought (using status checks, for example) a while ago, but never got around to actually doing any checks. If it's deemed worth the effort, I could revisit the idea.

alanhuang122 avatar Oct 29 '19 03:10 alanhuang122

I figured I'd get this up as an issue. I'm not sure if its worth the effort, but it seems like this could be used across all state repositories. Perhaps making it more valuable.

crass avatar Oct 29 '19 04:10 crass

The data tests and format tests workflows are an attempt at this.

warwickmm avatar Sep 07 '21 16:09 warwickmm