openeew-dashboard icon indicating copy to clipboard operation
openeew-dashboard copied to clipboard

Published 20 hours ago • verified publisher icon openeew

'Cannot read property push of undefined' after finalizing onboarding

Open rdkelley opened this issue 3 years ago • 5 comments

screen_after_add_to_device

rdkelley avatar May 22 '21 00:05 rdkelley

I've seen this in the context of the history object. Is that where you've already explored?

krook avatar May 22 '21 00:05 krook

Yeah, I imagine it has something to do with history but haven't had the chance to troubleshoot it yet. I did refactor some of how history is used in the latest PR, so if we're lucky it might already be fixed in the staging deployment. I'm going to investigate more tomorrow.

rdkelley avatar May 22 '21 06:05 rdkelley

Just tested -- this does not seem to be an issue in the current staging version, so I'm guessing the refactor of the history object in the latest PR fixed it. After we release v.0.8.0, we'll make sure that's accurate and close this issue.

rdkelley avatar May 24 '21 14:05 rdkelley

Sounds good. Even if it's not fixed, I think it's less a functional problem than a simple UI/navigation inconvenience. And if we can't get to the root cause later, maybe we just update error handling to look for it and ignore.

krook avatar May 24 '21 14:05 krook

Have we confirmed whether this has indeed been fixed @rdkelley?

krook avatar Oct 02 '21 17:10 krook