wg-build-test-release icon indicating copy to clipboard operation
wg-build-test-release copied to clipboard

[Test failure] TC_AUTHOR_142: Certificate preview not showing signatures

Open alexjmpb opened this issue 1 year ago • 6 comments

Release

Redwood

Expected behavior

"1. Go to a course with a certificate already set up 2. Preview certificate 3. Select print option. The layout (signatures, course name, ID, org...) are in place"

Actual behavior

The printing layout is correct overall except for the signatures which are not showing up.

Steps to reproduce

"1. Go to a course with a certificate already set up 2. Preview certificate 3. Review that signatures are not showing.

Additional information

image

image

This test case is indicated that also failed in Quince.

alexjmpb avatar May 23 '24 15:05 alexjmpb

Hello. Thank you for the report!

I reported this issue a while ago: https://github.com/openedx/wg-build-test-release/issues/177#issuecomment-1124246022. In Quince, it was marked as failing, but it actually wasn't: https://github.com/openedx/wg-build-test-release/issues/332#issuecomment-1849050582. Honor code certificates use the organization logo and signatory information, but do not include signature images, which are used only for verified certificates.

As you mentioned, I tested it out on the sandbox with the verified course mode, and this time it didn't work for honor or verified.

After trying a few things, I noticed you didn't have any signature images in your setup so I added them, and it worked: https://redwood.demo.edly.io/certificates/course/course-v1:Test+1+1?preview=verified, for both honor and verified. I'm not sure if this is the usual behavior though. I'll test in a quince environment to confirm.

mariajgrimaldi avatar May 23 '24 20:05 mariajgrimaldi

The behavior I reported also happens in quince, but since signatures are optional, it's a bit misleading. I'll report this elsewhere.

mariajgrimaldi avatar May 24 '24 11:05 mariajgrimaldi

I reported this in the #redwood_release_planning slack channel: https://openedx.slack.com/archives/C06AMDA6CAZ/p1716551180358129

mariajgrimaldi avatar May 24 '24 11:05 mariajgrimaldi

I would characterize this as a bug. I would expect the signatory info to display independently of the uploaded image. @cablaa77 - are you familiar with the intended certificate function?

jmakowski1123 avatar May 24 '24 13:05 jmakowski1123

I'll be taking a look into this. I'll make sure to report back once I know more. Thank you!

mariajgrimaldi avatar May 24 '24 20:05 mariajgrimaldi

I haven't had time to work on this so I'll unassign myself for now.

mariajgrimaldi avatar Aug 13 '24 18:08 mariajgrimaldi

Here is the PR fixing this issue: https://github.com/openedx/edx-platform/pull/36293. IMO this fixes the bug reported here, now, the signature information is displayed independently of whether there is an image present for verified/honor certificates:

Image

FYI @jmakowski1123 @crathbun428

mariajgrimaldi avatar May 05 '25 11:05 mariajgrimaldi

@crathbun428, friendly ping :)

mariajgrimaldi avatar May 29 '25 09:05 mariajgrimaldi

@mariajgrimaldi - looks good to me - thanks!

crathbun428 avatar May 29 '25 13:05 crathbun428

@efortish: can you help us with a backport to the release/teak branch? Thank you!

mariajgrimaldi avatar May 29 '25 16:05 mariajgrimaldi

Hello @mariajgrimaldi This is the backport PR in release/teak branch https://github.com/openedx/edx-platform/pull/36812

efortish avatar May 29 '25 18:05 efortish

@efortish, thank you very much :)

mariajgrimaldi avatar May 30 '25 08:05 mariajgrimaldi