wg-build-test-release icon indicating copy to clipboard operation
wg-build-test-release copied to clipboard

[LMS > Instructor dashboard > data download] text styling and layout issue in the table

Open fayyazahmed66 opened this issue 3 years ago • 10 comments

Steps to reproduce:

  1. Go to the lms > Instructor dashboard > data download
  2. Check the report Expected result: The report text layout should be properly styled.
    Actual result: Styling issue text style

fayyazahmed66 avatar Nov 01 '22 08:11 fayyazahmed66

label: olive testing

fayyazahmed66 avatar Nov 01 '22 08:11 fayyazahmed66

Hey @fayyazahmed66, this looks like a first good issue. Do you mind if I work on it?

johnny243 avatar Nov 01 '22 15:11 johnny243

@johnny243 sure you can.

fayyazahmed66 avatar Nov 02 '22 06:11 fayyazahmed66

Hi @johnny243. Have you been able to make some progress on this issue? please let us know if you need help from the community :)

jalondonot avatar Jan 23 '23 13:01 jalondonot

Hey @jalondonot thanks for reminding me about this task :)

I was able to narrow down the styling issue to the slickgrid library. Updating to the latest version fixes the issue:

image

I will create a PR with a fix shortly.

johnny243 avatar Jan 24 '23 01:01 johnny243

Thanks, @johnny243 ! did you get a chance to create the PR to fix this issue?

jalondonot avatar Feb 02 '23 15:02 jalondonot

@jalondonot yes, you can see it linked right below my previous comment

johnny243 avatar Feb 02 '23 15:02 johnny243

Update: the PR is waiting for a review.

mariajgrimaldi avatar Sep 05 '23 14:09 mariajgrimaldi

Update: the PR was closed due to inactivity.

mariajgrimaldi avatar Apr 29 '24 16:04 mariajgrimaldi